Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift windows Cygwin DLL import libraries #15193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Uplift windows Cygwin DLL import libraries #15193

wants to merge 2 commits into from

Conversation

Berrysoft
Copy link

  • needed to link std correctly

Related: rust-lang/rust#134999

@Berrysoft
add import library (.dll.a) file type for Cygwin
e9f8a17 
- needed to link std correctly

Signed-off-by: Ookiineko <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-cfg-expr Area: Platform cfg expressions S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2025
weihanglo
weihanglo reviewed Feb 17, 2025
View reviewed changes
src/cargo/core/compiler/build_context/target_info.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I assume it is pretty much the same as previous efforts?

If yes, it would be appreciated the PR title can stay similar to the old ones.

Also, do you have a successful CI build link so we can verify this is what we need?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it is pretty much the same as previous efforts?

Yes exactly.

I will adjust the test suite for this change; however the -cygwin target only works with no_std now, so I'm not sure if the test really verifies the change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the CI fails because -cygwin is a rather new target...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. Cargo doesn't have the CI infra to test cygwin, so it is not necessary to add tests here now.

I was more looking for whether you have a try build in rust-lang/rust with this Cargo change that verifies it meets your needs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more looking for whether you have a try build in rust-lang/rust with this Cargo change that verifies it meets your needs

Well... not now, then. I'm trying to build executables, but haven't tried dlls. Maybe it's not so hurry to make this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just want to make sure this is the correct change on your side, so you don't need to change it back-and-forth and wait for several rounds of Cargo submodule updates in rust-lang/rust.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to make sure this is the correct change on your side

I will check it in the future...

@weihanglo weihanglo changed the title add import library (.dll.a) file type for Cygwin Uplift windows Cygwin DLL import libraries Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@weihanglo weihanglo

Labels
A-cfg-expr Area: Platform cfg expressions S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berrysoft @rustbot @weihanglo