Skip to content

Warn on force approval with failed CI - #857

Merged
Kobzol merged 1 commit into
rust-lang:mainfrom
Sakib25800:force-approval-ci-warning
Sep 24, 2026
Merged

Kobzol merged 1 commit into
rust-lang:mainfrom
Sakib25800:force-approval-ci-warning

Conversation

@Sakib25800

Copy link
Copy Markdown
Member

Closes #852.

@Sakib25800

Copy link
Copy Markdown
Member Author

Maybe I should add two more tests for pending CI and successful CI to show the comment has no warning?

@Kobzol Kobzol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that is already covered by other tests, so this looks enough. Thanks!

View changes since this review

@Kobzol
Kobzol added this pull request to the merge queue Sep 24, 2026
Merged via the queue into rust-lang:main with commit c0c6301 Sep 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when force-approving a PR with failing CI

2 participants