Add table interactivity #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add search - Add sorting
Kobzol
reviewed
Oct 3, 2025
Kobzol
reviewed
Oct 3, 2025
Kobzol
approved these changes
Oct 5, 2025
| } | ||
| fn get_queue_status_priority(status: &QueueStatus) -> u32 { | ||
| match status { | ||
| QueueStatus::ReadyForMerge(_, _) => 0, |
There was a problem hiding this comment.
Seeing this function, I wonder if we should add the mergeability status into QueueStatus, and have something like QueueStatus::Unmergeable. Not sure if that would help with anything though, and definitely not for this PR anyway.
There was a problem hiding this comment.
We wouldn't be able to use that variant in the merge queue itself since it filters out un-mergeable PRs.
There was a problem hiding this comment.
That's not really different from NotApproved or Stalled, which should already never be returned from the SQL query, right?
There was a problem hiding this comment.
True. I guess there's no use for that variant (at least now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
I chose to use DataTable as the table library since it had the easiest setup and I found it the most ergonomic for our use case.
Currently the design looks poor as I plan to do the design as the last step - functionality first.