Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future news section #1499

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Conversation

Vrixyz
Copy link
Collaborator

@Vrixyz Vrixyz commented Apr 29, 2024

Part of #1417

To follow idea from #1417 (comment)

Not fully tested yet, the ci scripts (date, sed...) are very linux centric so my mac can't run them as-is (I might look into https://github.com/nektos/act, but I'd prefer a granular action to try only parts of those scripts, I wouldn't want to create a commit, issue, etc.

@janhohenheim
Copy link
Collaborator

Woah, that's a really good idea, thanks! Let me know when you're done so I can review it :)

@Vrixyz
Copy link
Collaborator Author

Vrixyz commented Apr 30, 2024

I considered linking to github.dev (the direct editor from within the browser), but I decided against because it makes it less likely that newcomers read the contribution guidelines.

So I kept the links closer to the original content.

In the long run there could be a script running to add how many pull requests we had etc but I won't go that far yet.

@janhohenheim
Copy link
Collaborator

@Vrixyz any updates on this? Should I review and maybe merge it?

@Vrixyz
Copy link
Collaborator Author

Vrixyz commented Jun 3, 2024

@janhohenheim please do so. I realized there was a call to action at the beginning of the post already linking to pull requests ; so that made me doubt the pertinence to add another one.

Also, Testing "act" locally proved a bit more convoluted than I thought so I didn't test it fully 😕

@janhohenheim janhohenheim marked this pull request as ready for review June 3, 2024 05:36
@janhohenheim
Copy link
Collaborator

janhohenheim commented Jun 3, 2024

I fixed the script and took the liberty to rewrite some minor phrasing. Merging now so that it gets included in N52. Thanks for adding the section; really good idea :)

@janhohenheim janhohenheim merged commit 866f8d7 into rust-gamedev:source Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants