Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for newsletter creation #1464

Merged
merged 9 commits into from
Apr 9, 2024

Conversation

janhohenheim
Copy link
Collaborator

@janhohenheim janhohenheim commented Feb 9, 2024

@janhohenheim janhohenheim changed the title Add GitHub Action for newsletter tracking issue Add GitHub Action for newsletter creation Feb 10, 2024
@janhohenheim janhohenheim requested a review from Vrixyz March 25, 2024 19:50
@janhohenheim janhohenheim requested a review from Vrixyz March 25, 2024 21:20
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, but looks good to me. I don't mind merging it once they're resolved, then resolving any other issues after it creates the first issue 👍🏻

@@ -1,5 +1,5 @@
+++
title = "This Month in Rust GameDev #{TODO} - {TODO} {TODO}"
title = "This Month in Rust GameDev #{{ NEWSLETTER_COUNTER }} - {{ NEWSLETTER_MONTH }} {{ NEWSLETTER_YEAR }}"
transparent = true
date = TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be templated too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this blank because it's supposed to be the date the post is actually published. I could fill in the deadline if you want (3rd of the next month).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we set a date that would be nice to have it done by (say the 1st if we really are ahead of timelines), and update once it does actually get published. Also, it fails building the site with just TODO 😅

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go: f1b2a80 (#1464)

@janhohenheim janhohenheim requested a review from AngelOnFira April 1, 2024 13:48
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good!

@AngelOnFira AngelOnFira merged commit 7c7ea93 into rust-gamedev:source Apr 9, 2024
1 check passed
@janhohenheim janhohenheim deleted the actions branch April 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants