Remove TODOs for secp256k1 callbacks #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well technically it's not exactly the same (these TODOs talk about runtime setting) but in practice we don't want to let users set these callbacks so setting them at compile time achieves those TODOs goal. |
|
Oh, you're right, it's not my day ... But I think I agree, we just don't want to provide the callback setters. So I'll update the commit message here (and that whitespace change that the GitHub editor introduced...) |
|
Heh, yeah, I'm fine removing "TODO do this, except I don't want to and I won't do it". |
|
Rebasing to include #148 should hopefully solve the CI problems |
We would not want to use these functions internally because we rely on USE_EXTERNAL_DEFAULT_CALLBACKS to provide the callbacks at link time, see f7a4a7e. Moreover, we would not want to export the functions either.
real-or-random
force-pushed
the
remove-callback-todos
branch
from
e54233b to
255d1dd
Compare
So this is ready for review. |
elichai
approved these changes
Aug 20, 2019
jonasnick
approved these changes
Aug 21, 2019
|
Can't merge because travis is still shown as pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These TODOs have been solved in #115.