-
Notifications
You must be signed in to change notification settings - Fork 67
Make unicode normalization optional #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e64a0d5
to
93330e9
Compare
chinese-simplified = [ "unicode-normalization" ] | ||
chinese-traditional = [ "unicode-normalization" ] | ||
czech = [] | ||
french = [] | ||
italian = [] | ||
japanese = [] | ||
korean = [] | ||
japanese = [ "unicode-normalization" ] | ||
korean = [ "unicode-normalization" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk if that's the right way to go about it, but it seems reasonable to want UN if you are dealing with these languages. I can also make it an entirely optional feature, which is cleaner but imo risks misuse.
rand = [ "crate_rand", "rand_core" ] | ||
alloc = [ "unicode-normalization" ] | ||
alloc = [] | ||
unicode-normalization = [ "dep:unicode-normalization", "alloc" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't work in old rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenroose What was the ancient Rust version we need to get it to work on? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elsirion I guess we don't really need to use dep:
which is somehow recent addition.
And we can have unicode-normalization-std
to avoid using ?
.
Potential solution for #28 (comment)
With default features this is the dependency tree now: