v28: Add support for submitpackage
#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tnull |
tcharding
force-pushed
the
11-28-submitpackage
branch
from
4184d7f to
3e17653
Compare
apoelstra
reviewed
Nov 28, 2024
integration_test/src/lib.rs
Outdated
| /// | ||
| /// # Returns | ||
| /// | ||
| /// The receive address and the transaction. |
There was a problem hiding this comment.
In 3e17653:
Trailing whitespace.
There was a problem hiding this comment.
Were are the git hooks!!!
tcharding
force-pushed
the
11-28-submitpackage
branch
from
3e17653 to
b676790
Compare
|
Otherwise 3e17653 looks good. Also CI is failing. I didn't look at why. |
Bitcoin Core introduced a new RPC method `submitpackage`. Add support for it including integration testing. This work was originally done by tnull a while ago over on the old `rust-bitcoind-json-rpc` repository (PR: rust-bitcoin#23). I took his changes and updated the code with the ideas I've learned recently fleshing out v17. <Co-developed-by>: Elias Rohrer <[email protected]>
tcharding
force-pushed
the
11-28-submitpackage
branch
from
b676790 to
7c3024c
Compare
|
Thanks man, CI was docs. Should be fixed now. |
|
The PR description is wrong - |
Sorry! 😁 |
|
No stress man, shit happens. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
7c3024cad7ecc41d943a0f5135dc4355bc827c01 v28: Add support for submitpackage (Tobin C. Harding) Pull request description: Bitcoin Core introduced a new RPC method `submitpackage`. Add support for it including integration testing. This work was originally done by tnull a while ago over on the old `rust-bitcoind-json-rpc` repository (PR: rust-bitcoin/rust-bitcoind-json-rpc#23). I took his changes and updated the code with the ideas I've learned recently fleshing out v17. Patch includes `<Co-developed-by>` tag. Close: #7 ACKs for top commit: apoelstra: ACK 7c3024cad7ecc41d943a0f5135dc4355bc827c01; successfully ran local tests Tree-SHA512: 35a6a43b472633436069867619ca82440c777b675b2c6b9e4baff85f5461241dd7f3fca3e26d5d7c98e1df3b38d5aa41d448b4e657c3ad99a1ed66bace656926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcoin Core introduced a new RPC method
submitpackage. Add support for it including integration testing.This work was originally done by tnull a while ago over on the old
rust-bitcoind-json-rpcrepository (PR: rust-bitcoin/rust-bitcoind-json-rpc#23).I took his changes and updated the code with the ideas I've learned recently fleshing out v17.
Patch includes
<Co-developed-by>tag.Close: #7