Model GlobalAllocs
#677
Open
Model GlobalAllocs
#677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
commented
Sep 9, 2025
Comment on lines
+622
to
+627
| @dataclass | ||
| class GenericArgKind: | ||
| @staticmethod | ||
| def from_dict(dct: dict[str, Any]) -> GenericArgKind: | ||
| _LOGGER.warning(f'Unparsed GenericArgKind data encountered: {dct}') | ||
| return GenericArgKind() |
There was a problem hiding this comment.
I pruned further modeling here, but GenericArgKind can be turned into a base class if needed.
tothtamas28
force-pushed
the
global-allocs
branch
from
1413332 to
d864ad4
Compare
dkcumming
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
I think this looks good! @jberthold do you see anything that would need changing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing cases for
SMIR.allocs