Merged
Conversation
Contributor
Author
|
@milseman Are you okay with these changes? Do you want to remain listed as an author? And would you be alright with us licensing this under a GPL Free Software License, so it can be added to MELPA? |
Contributor
Author
|
@ehildenb or @dwightguth Could you merge this? I'm trying to reach @milseman about the GPL license, but haven't heard back yet. But it should not be a blocker for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New features:
k-mode.elfor MELPA support, as described in Marmalade package format #6This also replaces the current
k-mode.elwith the new one. As far as I can tell, the existingk-mode.elis a very slight variation of the legacyk3-mode.el. I think we are better off using this newk-mode.elfor both vanilla Emacs and Spacemacs, using additional customization options for users who want personalized highlighting.