Skip to content

Adds a JSON marshalling handler for loader types: #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

Adds a JSON marshalling handler for loader types: #17

merged 2 commits into from
May 6, 2025

Conversation

dfuentes
Copy link
Contributor

@dfuentes dfuentes commented May 5, 2025

  • When martialling, omit the "Builder:" layer of json and just marshal the loaded type directly.

@dfuentes
Adds a JSON marshalling handler for loader types:
6d6070c 
- When martialling, omit the "Builder:" layer of json and just marshal
the loaded type directly.
@dfuentes dfuentes force-pushed the df/marshal-loader-types branch from 44ef3b1 to 6d6070c Compare May 5, 2025 21:02
@dfuentes dfuentes requested a review from abraithwaite May 5, 2025 21:08
abraithwaite
abraithwaite approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@abraithwaite abraithwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a simple sanity check test to this but otherwise LGTM!

@dfuentes dfuentes merged commit e49f8fb into main May 6, 2025
1 check passed
@dfuentes dfuentes deleted the df/marshal-loader-types branch May 6, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abraithwaite abraithwaite abraithwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfuentes @abraithwaite