Add a VRAM column to the cloud table output #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a VRAM column to the cloud table output
Adds a
VRAM
column to thecloud
sub-command output (resolves #183)Example:
I think we need to discuss how this column should be presented, and where, so consider the PR in the current form in a state of "here's a working implementation, let's discuss what's good or bad about it". I'm happy to change this to fit the project vision.
Now, there are three obvious questions that need settling:
All three questions center on the same concern; backwards compatibility. If the project has a strict "don't change the default output" (risk breaking screen scrapers), then the flag option seems the only viable option. On the other hand, if the project's focus is a good set of sensible defaults to minimize the cognitive load and address the users' needs as well as can be by default, then that would indicate the first option in No 2 to be the preferred one.
In either of the two options No 2 highlights, the column location in No 3 is still something that must be decided on.
Personally I'd prefer to see VRAM right after the GPU type, since that tells me all I need to know; How fast is the GPU (will it complete my task in time), and how much data can I fit into it. If either of those constraints are not met, then I can't move forward with an initiative. The rest of the columns present secondary (lower priority) concerns. As such that would merit the two most important columns be listed first.
But again, I'm open to other perspectives on this. What do you think, current good enough or would you want to see something changed?
How I tested it
Interactively with debugger.