Skip to content

Conversation

@CCatRS
Copy link
Contributor

@CCatRS CCatRS commented Oct 14, 2025

Added the following wave data to submission:

  • Good premove or not
  • QS ticks per lobby
  • Wave times
  • If the wave was reset or not
  • QS spawn coordiantes in lobby

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 14, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 14, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Oct 14, 2025

@SkylerPIlot do you approve this change?

You can also add @CCatRS to the authors field in the manifest file (example - https://github.com/runelite/plugin-hub/blob/master/plugins/dink#L3)

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 14, 2025
@CCatRS
Copy link
Contributor Author

CCatRS commented Oct 14, 2025

@SkylerPIlot do you approve this change?

You can also add @CCatRS to the authors field in the manifest file (example - https://github.com/runelite/plugin-hub/blob/master/plugins/dink#L3)

With permission from @SkylerPIlot can I update this PR to include myself as an author?

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 14, 2025
@riktenx
Copy link
Member

riktenx commented Oct 14, 2025

Yes, as long as they provide explicit approval here.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 14, 2025
@SkylerPIlot
Copy link
Contributor

I both approve of the change as well as adding cat to the authors of the plugin

@runelite-github-app runelite-github-app bot removed waiting for author waiting for the pr author to make changes or respond to questions non-author plugin change labels Oct 14, 2025
@LlemonDuck
Copy link
Contributor

downgrade the log.infos in logWaveData to log.debug. everything else lgtm

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 19, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 20, 2025
@CCatRS
Copy link
Contributor Author

CCatRS commented Oct 20, 2025

downgrade the log.infos in logWaveData to log.debug. everything else lgtm

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants