Skip to content

Conversation

@Mattb2291
Copy link
Contributor

@Mattb2291 Mattb2291 commented Oct 9, 2025

Finally a way to hide world map icons!

This plugin compliments the existing 'World Map' and 'Minimap' client plugins, but allows much more customisation on the map icons.
minimap

image image

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 9, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 9, 2025

Internal use only: Reviewer details Maintainer details

@Mattb2291 Mattb2291 changed the title Create worldmapextended plugin Create Better Maps plugin Oct 16, 2025
@Mattb2291 Mattb2291 mentioned this pull request Oct 20, 2025
@riktenx
Copy link
Member

riktenx commented Oct 20, 2025

Per #9278 (comment) are you still trying to submit this? We would prefer collaboration rather than a new plugin.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 20, 2025
@Mattb2291
Copy link
Contributor Author

Per #9278 (comment) are you still trying to submit this? We would prefer collaboration rather than a new plugin.

Hi, I'm still trying to submit this yes - I don't think this would naturally combine with any of the existing or submitted plugins (It's why I queried the pull request for the HD Minimap) as they do completely different things. This allows full customisation of map icons both on the world map and the minimap. The collaboration aspect would simply be ensuring any of the coding is compatible with the other plugin (just as this is intended to ensure compatibility with the existing World Map client plugin - if the user has set the client plugin to display advanced tooltips, this plugin identifies a clash if they set the icons to hidden etc). I've designed this to compliment the other plugins since it does something completely different to what they do.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 20, 2025
@Mark7625
Copy link
Contributor

Mark7625 commented Oct 21, 2025

Per #9278 (comment) are you still trying to submit this? We would prefer collaboration rather than a new plugin.

Hi, I'm still trying to submit this yes - I don't think this would naturally combine with any of the existing or submitted plugins (It's why I queried the pull request for the HD Minimap) as they do completely different things. This allows full customisation of map icons both on the world map and the minimap. The collaboration aspect would simply be ensuring any of the coding is compatible with the other plugin (just as this is intended to ensure compatibility with the existing World Map client plugin - if the user has set the client plugin to display advanced tooltips, this plugin identifies a clash if they set the icons to hidden etc). I've designed this to compliment the other plugins since it does something completely different to what they do.

How is mine any different apart from I don't support world map, but i'm more willing to work with you to support this seems stupid to make a another plugin for it tbh when my plugin has 41k installs I cloned yours and all yours does it disables map icons and that can be added to mine very easy and as for ' coding is compatible with the other plugin' it makes no sense rlly since you are basically just using a crap ton of enums if anything they can be merged without any edits to any

@Mattb2291
Copy link
Contributor Author

How is mine any different apart from I don't support world map, but i'm more willing to work with you to support this seems stupid to make a another plugin for it tbh when my plugin has 41k installs I cloned yours and all yours does it disables map icons and that can be added to mine very easy and as for ' coding is compatible with the other plugin' it makes no sense rlly since you are basically just using a crap ton of enums if anything they can be merged without any edits to any

So I think you are right - I am happy to work with you and add it to yours, that was what I thought the comment meant. I meant that I don't think there are any other plugins that currently hide the world map icons (that I could see), therefore yes I still think that functionality is useful to have in the game. I am happy to add it to yours, and that's what I meant by 'The collaboration aspect would simply be ensuring any of the coding is compatible with the other plugin' - I would need to make sure the world map bits is compatible with yours given yours doesn't currently look at the world map at all. I think it's a misunderstanding.

@tylerwgrass
Copy link
Member

This seems like a good idea for combining, yes.
The name of the HD Minimap plugin can be changed to something more generic and support both cases.
This benefits both users and yourself as your features will immediately be available to the userbase of the original plugin, and users do not have to separately install two different plugins for a similar feature set

@Mattb2291 Mattb2291 closed this Oct 21, 2025
@Mark7625
Copy link
Contributor

Mark7625 commented Oct 21, 2025

How is mine any different apart from I don't support world map, but i'm more willing to work with you to support this seems stupid to make a another plugin for it tbh when my plugin has 41k installs I cloned yours and all yours does it disables map icons and that can be added to mine very easy and as for ' coding is compatible with the other plugin' it makes no sense rlly since you are basically just using a crap ton of enums if anything they can be merged without any edits to any

So I think you are right - I am happy to work with you and add it to yours, that was what I thought the comment meant. I meant that I don't think there are any other plugins that currently hide the world map icons (that I could see), therefore yes I still think that functionality is useful to have in the game. I am happy to add it to yours, and that's what I meant by 'The collaboration aspect would simply be ensuring any of the coding is compatible with the other plugin' - I would need to make sure the world map bits is compatible with yours given yours doesn't currently look at the world map at all. I think it's a misunderstanding.

Mine works fine with the world map atm for hiding normal icons as its based on same thing as the minimap, Yes it does not hide the custom icons from world map plugin but be easy to add, add me anyways and we can talk about it :), I was thinking about renaming the plugin to "Enchanted Map" anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants