-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Create Better Maps plugin #9229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New plugin |
|
Internal use only: Reviewer details Maintainer details |
|
Per #9278 (comment) are you still trying to submit this? We would prefer collaboration rather than a new plugin. |
Hi, I'm still trying to submit this yes - I don't think this would naturally combine with any of the existing or submitted plugins (It's why I queried the pull request for the HD Minimap) as they do completely different things. This allows full customisation of map icons both on the world map and the minimap. The collaboration aspect would simply be ensuring any of the coding is compatible with the other plugin (just as this is intended to ensure compatibility with the existing World Map client plugin - if the user has set the client plugin to display advanced tooltips, this plugin identifies a clash if they set the icons to hidden etc). I've designed this to compliment the other plugins since it does something completely different to what they do. |
How is mine any different apart from I don't support world map, but i'm more willing to work with you to support this seems stupid to make a another plugin for it tbh when my plugin has 41k installs I cloned yours and all yours does it disables map icons and that can be added to mine very easy and as for ' coding is compatible with the other plugin' it makes no sense rlly since you are basically just using a crap ton of enums if anything they can be merged without any edits to any |
So I think you are right - I am happy to work with you and add it to yours, that was what I thought the comment meant. I meant that I don't think there are any other plugins that currently hide the world map icons (that I could see), therefore yes I still think that functionality is useful to have in the game. I am happy to add it to yours, and that's what I meant by 'The collaboration aspect would simply be ensuring any of the coding is compatible with the other plugin' - I would need to make sure the world map bits is compatible with yours given yours doesn't currently look at the world map at all. I think it's a misunderstanding. |
|
This seems like a good idea for combining, yes. |
Mine works fine with the world map atm for hiding normal icons as its based on same thing as the minimap, Yes it does not hide the custom icons from world map plugin but be easy to add, add me anyways and we can talk about it :), I was thinking about renaming the plugin to "Enchanted Map" anyways |
Finally a way to hide world map icons!
This plugin compliments the existing 'World Map' and 'Minimap' client plugins, but allows much more customisation on the map icons.
