Update flipping-copilot to v1.7.4 #8538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cbrewitt
commented
Jul 21, 2025
cbrewitt
commented
- Add more advanced flip history management/analysis
- Add select all/deselect all options to item blocklist
cbrewitt
changed the title
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
I don't like what you have going for ClientThreadUtil#executeInClientThread, if you admit it's a code smell then just fix the code that uses it? It makes the plugin much harder to review overall, and anything calling it from the EDT would block the EDT. |
LlemonDuck
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
|
We’ve now removed ClientThreadUtil#executeInClientThread completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.