Skip to content

Update DropTracker to v5.0.1 #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update DropTracker to v5.0.1 #8523

wants to merge 8 commits into from

Conversation

joelhalen
Copy link
Contributor

We've made a large number of changes with this update:

  • Added Quest, pet and experience tracking functionality (courtesy to the Dink team for the heavy lifting <3)
  • Refactored our event handlers to move them all into their own classes; extending upon a base (another thanks to Dink for the inspiration)
  • Fixed KCs being sent alongside drop submissions--which were sending blank.

Most of the codebase has been redesigned to create a more manageable codebase moving forward & to provide players a more intuitive way of viewing leaderboards and player/group stats from directly inside the client.

Implemented a variety of new functionality, while refactoring large portions of our codebase to make it more manageable and clear.
@runelite-github-app
Copy link

runelite-github-app bot commented Jul 20, 2025

Do not create new Gson instances.
Removed deprecated WidgetID usage.
@runelite-github-app
Copy link

runelite-github-app bot commented Jul 20, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Remove system i/o...
@LlemonDuck
Copy link
Contributor

reflection is not allowed in the plugin hub

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 24, 2025
Remove use of reflection (@OSRSKoeppy)
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 26, 2025
Use better encapsulation to avoid java.reflect usage
@LlemonDuck
Copy link
Contributor

LlemonDuck commented Jul 27, 2025

replace printStackTrace with logger statements

in order to make this easier to review, can you add if (config.useApi()) checks into DropTrackerApi itself, at the top of each method? Feel free to check it outside as well if you want to handle it differently but this at least ensures calling the method always checks the config option

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 27, 2025
@raiyni
Copy link
Member

raiyni commented Aug 6, 2025

It also looks you have based quite a bit of your code on Dink. You will need to include their license.

Added more explicit checks for API config status inside each outgoing method. Implemented better functionality for tracking the new Doom boss times.
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Aug 10, 2025
I've been away the past few days; these changes are courtesy @OSRSKoeppy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants