-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update DropTracker to v5.0.1 #8523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Implemented a variety of new functionality, while refactoring large portions of our codebase to make it more manageable and clear.
Do not create new Gson instances.
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Remove system i/o...
reflection is not allowed in the plugin hub |
Remove use of reflection (@OSRSKoeppy)
Use better encapsulation to avoid java.reflect usage
replace printStackTrace with logger statements in order to make this easier to review, can you add |
It also looks you have based quite a bit of your code on Dink. You will need to include their license. |
Added more explicit checks for API config status inside each outgoing method. Implemented better functionality for tracking the new Doom boss times.
I've been away the past few days; these changes are courtesy @OSRSKoeppy
We've made a large number of changes with this update:
Most of the codebase has been redesigned to create a more manageable codebase moving forward & to provide players a more intuitive way of viewing leaderboards and player/group stats from directly inside the client.