Remove unnecessary param from logging helper. #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2024
Merged
This was referenced Aug 14, 2024
rohinb2
force-pushed
the
08-13-Pass_run_name_from_client_side_enforce_requirement_server_side_and_ensure_uniqueness
branch
from
7d3a35c
to
005b2ee
Compare
rohinb2
force-pushed
the
08-14-Remove_unnecessary_param_from_logging_helper
branch
from
8247e24
to
e2cd24a
Compare
jlewitt1
approved these changes
Aug 15, 2024
rohinb2
force-pushed
the
08-13-Pass_run_name_from_client_side_enforce_requirement_server_side_and_ensure_uniqueness
branch
from
005b2ee
to
a715c25
Compare
rohinb2
force-pushed
the
08-14-Remove_unnecessary_param_from_logging_helper
branch
from
e2cd24a
to
8396da1
Compare
rohinb2
force-pushed
the
08-13-Pass_run_name_from_client_side_enforce_requirement_server_side_and_ensure_uniqueness
branch
from
a715c25
to
61b683f
Compare
rohinb2
force-pushed
the
08-14-Remove_unnecessary_param_from_logging_helper
branch
from
8396da1
to
2ebecf3
Compare
rohinb2
force-pushed
the
08-13-Pass_run_name_from_client_side_enforce_requirement_server_side_and_ensure_uniqueness
branch
from
61b683f
to
ed018d8
Compare
rohinb2
force-pushed
the
08-14-Remove_unnecessary_param_from_logging_helper
branch
from
2ebecf3
to
93b13f7
Compare
rohinb2
changed the base branch from
08-13-Pass_run_name_from_client_side_enforce_requirement_server_side_and_ensure_uniqueness
to
graphite-base/1149
rohinb2
force-pushed
the
08-14-Remove_unnecessary_param_from_logging_helper
branch
from
93b13f7
to
a76a48d
Compare
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.