Open
Conversation
ndaemy
requested changes
Feb 10, 2026
Member
ndaemy
left a comment
ndaemy
left a comment
There was a problem hiding this comment.
- hierarchy가 피그마 시안과 맞지 않는 것 같아요. 제가 읽었을 때는 primitive/semantic → colors/typography.. 가 아니라 colors → primitive/semantic 이 맞는거 같은데, 지금 이 부분이 조금 불명확하게 정해진 것 같아서 논의를 조금 해봐야 할 거 같아요!
- 이미 만들어진 파일과 새로 만드는 파일이 단수/복수형 표기가 맞지 않아서 통일하면 좋을 것 같아요. 단수형이 나을 것 같습니다.
- $schema 의 부적절한/일관되지 않은 사용이 있습니다. 확인해보시고 수정 부탁드려요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.