Skip to content

Add the possibility to provide a header image and add Dresden.rb logos #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the possibility to provide a header image and add Dresden.rb logos #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798ea5f
Add a way to provide a header image for the header
richardboehme Oct 23, 2025
eb34f4a
Update Dresden.rb logos and add header image
richardboehme Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed app/assets/images/labels/dresdenrb-icon.png
View file
Open in desktop
Binary file not shown.
Binary file added app/assets/images/labels/dresdenrb.ico
View file
Open in desktop
Binary file not shown.
Binary file modified app/assets/images/labels/dresdenrb.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/labels/dresdenrb/header.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions app/assets/stylesheets/application.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ header
margin-left: 0
width: 100px

#header_image
max-height: 250px
Copy link
Collaborator

@salzig salzig Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the best we can to right now. 🤷

Copy link
Contributor Author

@richardboehme richardboehme Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I wasn't sure whats best here. The normal logo is restricted to 100px width but restricting width seemed wrong for the a header image.


#title, &:hover, &:active, &:visited
color: $title-color
text-decoration: none
Expand Down
6 changes: 6 additions & 0 deletions app/assets/stylesheets/labels/dresdenrb.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#nav
.navbar-brand
padding-top: 0
padding-bottom: 0
img.label
max-height: 42px
8 changes: 8 additions & 0 deletions app/helpers/home_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,12 @@ def contact_text
concat '.'
end
end

def header_image_path
File.join('labels', Whitelabel[:label_id], 'header.png')
end

def header_image_available?
Rails.root.join('app', 'assets', 'images', header_image_path).exist?
end
end
19 changes: 12 additions & 7 deletions app/views/application/_headline.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
header.d-none.d-xl-block
.row
.col-lg-2.text-center
= link_to(root_path, title: title) do
=image_tag("labels/#{Whitelabel[:label_id]}.png", title: title, id: :logo)
- if header_image_available?
.col-lg-12
= link_to(root_path, title: title) do
= image_tag(header_image_path, title: title, id: :header_image)
- else
.col-lg-2.text-center
= link_to(root_path, title: title) do
=image_tag("labels/#{Whitelabel[:label_id]}.png", title: title, id: :logo)

.col-lg-10
= link_to(root_path, id: :title, title: title) do
h1= title
h2.mt-4= subtitle
.col-lg-10
= link_to(root_path, id: :title, title: title) do
h1= title
h2.mt-4= subtitle
Loading