avm2: Port Namespace to ActionScript #17792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-namespace-as
branch
from
39b582a
to
43721d9
Compare
Lord-McSweeney
force-pushed
the
avm2-namespace-as
branch
2 times, most recently
from
50c2db4
to
021277b
Compare
|
This looks good to me, but I don't feel confident enough to review the |
danielhjacobs
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-namespace-as
branch
3 times, most recently
from
4f0d23f
to
f30da89
Compare
|
FWIW, Clippy is not happy about some lifetimes not being removed in this. |
Lord-McSweeney
force-pushed
the
avm2-namespace-as
branch
from
f30da89
to
fa432c1
Compare
added 3 commits
September 25, 2024 13:18
Ensure that those classes are loaded before the other classes.
Lord-McSweeney
force-pushed
the
avm2-namespace-as
branch
from
fa432c1
to
fcf88f0
Compare
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slows down
new Namespace()by about 220%, but that's not hot anyway.