desktop: Change default value of Open Links to "Ask" #17690
Conversation
…#17432) Change the default value of the "Open Links" setting from "Allow" to "Ask". Having the default value of "Allow" may raise security concerns. More details are in issue ruffle-rs#17432, which this commit solves.
|
Because the prompt can become annoying I would prefer to wait until we have a "don't ask again" checkbox in the dialog to do this |
I agree, but should the checkbox disable the prompt only for the URL, the SWF, or the entire session? |
|
On web, @n0samu s main concern was old flash based navigation buttons which shouldn't get a prompt for each click. So on web, the checkbox would need to be for the entire session. On desktop, that's different though as the website doesn't replace the current SWF file, so I'd only make it for the current SWF file (if possible / easy to implement, I think the whole session is okay as well). |
danielhjacobs
added
security
Change the default value of the "Open Links" setting from "Allow" to "Ask".
Having the default value of "Allow" may raise security concerns.
More details are in issue #17432, which this PR resolves.