chore: oauth v2 stats refactor #5262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpj2292
commented
Nov 4, 2024
| ) (int, *AuthResponse, error) { | ||
| actionType := strings.Join(strings.Fields(strings.ToLower(logTypeName)), "_") |
There was a problem hiding this comment.
For reference
> strings.Join(strings.Fields(strings.ToLower("Refresh Token")), "_")
refresh_token
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5262 +/- ##
==========================================
- Coverage 73.34% 73.31% -0.03%
==========================================
Files 424 424
Lines 59946 59962 +16
==========================================
- Hits 43969 43964 -5
- Misses 13536 13543 +7
- Partials 2441 2455 +14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way in which stats are written is not easily readable. Through this PR, we are trying to make the stat emission in oauthv2 module a bit more developer friendly and readable
Linear Ticket
Resolves INT-2744
Security