make Sign Up more obvious #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairedfox
force-pushed
the
issue_872_make_sign_up_obvious
branch
from
078b150 to
0d6f9c4
Compare
solebared
approved these changes
Apr 5, 2021
| @@ -38,6 +38,7 @@ | |||
| </div> | |||
| <div class="" id="login_button"> | |||
| <%= f.button :submit, "Log in", class: "button is-primary" %> | |||
| <%= link_to "Sign Up", new_user_registration_path, class: "button is-success" %> | |||
There was a problem hiding this comment.
I think this should probably not live inside the #login_button div and instead be in a separate sibling div.
There was a problem hiding this comment.
Thank you for reminding me. I'll fix this one and merge.
| @@ -2,7 +2,7 @@ | |||
| <%= link_to "Log in", new_session_path(resource_name) %><br /> | |||
| <% end %> | |||
|
|
|||
| <%- if devise_mapping.registerable? && controller_name != 'registrations' %> | |||
| <%- if devise_mapping.registerable? && !controller_name.in?(['registrations', 'sessions']) %> | |||
hairedfox
force-pushed
the
issue_872_make_sign_up_obvious
branch
from
0d6f9c4 to
56acab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
How
Testing
Next Steps
Outstanding Questions, Concerns and Other Notes
Accessibility
Security
Meta
Pre-Merge Checklist