Remove OpenStructs from code base #4832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change State too Status in view status in index
Bumps [redis](https://github.com/redis/redis-rb) from 5.2.0 to 5.3.0. - [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md) - [Commits](redis/redis-rb@v5.2.0...v5.3.0) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brock Wilcox <[email protected]>
…m Categories changes to a yes/no! Obviously wrong! (#4668) * fix(partner_groups_controller): assign item_categories when create or edit params are invalid * fix: typo
Bumps [puma](https://github.com/puma/puma) from 6.4.2 to 6.4.3. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v6.4.2...v6.4.3) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove filtering for active attribute on children query * Add spec that tests for child item requests
…-status Change State to Status on Distribution Table
Add partner group to organization. Add new partner for seed
* validate the presence of business name for a vendor add validation for business name on vendor model, skip validation in provideable when the model is a vendor to prevent duplicate errors on invalid form submission, specs for both changes * create migration to update a vendor's business name to its contact name if business name is blank * move product drive participant validations out of provideable and into model instead of skipping when the provideable model is vendor * fix arg name
* Change button from 'Promote to Admin' to 'Edit User' * Replace system spec with request spec for link for editing user * Replace system spec with request spec for link for editing user
…n beside Add a Partner link. Add system tests to ensure the Partner cta section has 2 links. (#4710) Co-authored-by: Athira Kadampatta <[email protected]>
# Conflicts: # app/controllers/distributions_controller.rb # spec/rails_helper.rb
* Add view password functionality to login form * refactored the password visiblity toggle into a Stimulus controller
user docs cont v: draft inventory section of user guide
User docs cont vi: draft exports section of user guide
Fix inventory seeding for storage location from donations
build(deps): bump rails from 7.1.3.4 to 7.2.2
* Fix unexpected issued_at behavior when date field empty. Previously before_save and before_create callbacks set the value for issued_at created_at end of day if no datetime was provided. This prevented records being saved with no issue date. But it caused unexpected behavior when creating or updating a donation/purchase/distribution with an empty issued_at field, silently changing the issued_at date to something potentially incorrect. * Fix missing partner dropdown options of distribution update fail * Revert partner list fix
* Fix unitialized money_rails constant error * Fix require statement file_path and edit comment
This test expects the requests in the export to be in a particular order, but no order is applied to the requests passed in and no order is defined in the ExportCreateService itself, hence the flakiness. Example failure: https://github.com/rubyforgood/human-essentials/actions/runs/12353561322/job/34472934783#step:7:1433
…#4801) * Migration for partner agency cleanup re issue 4241. Necessary step, but does not complete that issue. * save! instead of save * save! instead of save
coalest
force-pushed
the
replace-open-structs
branch
from
107ec8b to
eb6007c
Compare
coalest
changed the title
|
Made the requested changes, so this is ready for another round of review. |
dorner
requested changes
Dec 19, 2024
app/models/result.rb
Outdated
| super | ||
| end | ||
|
|
||
| alias_method :success?, :success |
There was a problem hiding this comment.
Do we need a success attribute? Why wouldn't we just define a method?
def success? = error.nil?There was a problem hiding this comment.
Yea I was debating this internally and wasn't sure which was better. Will fix.
* Fix flaky family requests system spec * Fix flaky system partners children spec
…to 6.5.0 (#4813) * build(deps-dev): bump factory_bot_rails from 6.4.3 to 6.4.4 Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.4.3 to 6.4.4. - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases) - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md) - [Commits](thoughtbot/factory_bot_rails@v6.4.3...v6.4.4) --- updated-dependencies: - dependency-name: factory_bot_rails dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Fix merge conflicts with main * Update puma to 6.5.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Orner <[email protected]> Co-authored-by: Brock Wilcox <[email protected]> Co-authored-by: Cory Streiff <[email protected]>
We were saving a new distribution (which causes a redirect to that distribution's show page) and then immediately clicking on the distributions index page (which redirects as well). This introduced a race condition that was flaky when we tried to click a link that didn't exist on the page.
We were expecting the `family_zipcodes_list` to have a certain order but no order is guaranteed in the request.
* lowered pagination threshold in dev and staging using kaminari * Trigger Build
coalest
force-pushed
the
replace-open-structs
branch
from
e032fda to
ef0878a
Compare
|
I'm going to have trouble figuring out what to test on this -- is there a way I can get just the relevant commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
While thinking about performance, I noticed some usage of OpenStructs in the app. While they are only used in a few places, let's get rid of them.
From the official documentation:
The performance impact in our application will be small, but I don't see a strong reason to keep them around.
Type of change
How Has This Been Tested?
Strictly internal refactor. No additional tests added.