Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1180: Add new images to app root page #1305

Merged
merged 5 commits into from
Dec 29, 2024

Conversation

jasonwang7517
Copy link
Contributor

🔗 Issue

Issue

✍️ Description

  • Adds new screenshots to the root page
  • Replaces gray background with CSS shadow

📷 Screenshots/Demos

Screen.Recording.2024-12-27.at.6.05.05.PM.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is a little fatter since when it's set to the same ratio as the other pictures, we get the card view which is full of "coming soon" pictures. Not sure if that matters a ton but I thought it was worth pointing out.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now! Better than the placeholder image we had.

@kasugaijin
Copy link
Collaborator

kasugaijin commented Dec 28, 2024

@jasonwang7517 this is looking good.
Can we get rid of this outer background div entirely so we are just left with the image (rounded with small shadow)? If we need the div, can we just remove the border shadow from it so it is imperceptable?

image

@jasonwang7517
Copy link
Contributor Author

@jasonwang7517 this is looking good. Can we get rid of this outer background div entirely so we are just left with the image (rounded with small shadow)? If we need the div, can we just remove the border shadow from it so it is imperceptable?

image

Sure! I made the shadows small instead of large and it may be a little hard to see so let me know if you want me to change the shadows back to large. Here is how they look small:
image

@kasugaijin
Copy link
Collaborator

@jasonwang7517 I think small looks fine!

@kasugaijin kasugaijin merged commit f6ff60d into rubyforgood:main Dec 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants