Add unit tests for XMLRPC::CGIServer #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The do not work out of the box, I'm sure this can be fixed but I have no idea how to do that.
|
I've disabled these new tests on Windows platforms, the CGI structure needs an executable file and the usual |
kou
reviewed
Apr 30, 2025
| end | ||
|
|
||
| def test_client_server | ||
| omit("The CGI file does not work on Windows") if RUBY_PLATFORM =~ /(mswin|mingw)/ |
There was a problem hiding this comment.
We can use Gem.win_platform?:
Suggested change
| omit("The CGI file does not work on Windows") if RUBY_PLATFORM =~ /(mswin|mingw)/ | |
| omit("The CGI file does not work on Windows") if Gem.win_platform? |
| tempfile.close | ||
| File.chmod(0755, tempfile.path) | ||
|
|
||
| [false].each do |use_ssl| |
There was a problem hiding this comment.
Suggested change
| [false].each do |use_ssl| | |
| use_ssl = false |
|
|
||
| [false].each do |use_ssl| | ||
| option = setup_http_server_option(use_ssl) | ||
| with_server(option, WEBrick::HTTPServlet::CGIHandler, tempfile.path) {|addr| |
There was a problem hiding this comment.
Suggested change
| with_server(option, WEBrick::HTTPServlet::CGIHandler, tempfile.path) {|addr| | |
| with_server(option, WEBrick::HTTPServlet::CGIHandler, tempfile.path) do |addr| |
|
|
||
| def cgi_bin_script | ||
| <<~RUBY | ||
| #!/usr/bin/env ruby |
There was a problem hiding this comment.
Suggested change
| #!/usr/bin/env ruby | |
| #!#{Gem.ruby} |
| end | ||
|
|
||
| s.set_default_handler do |name, *args| | ||
| raise XMLRPC::FaultException.new(-99, "Method #{name} missing" + |
There was a problem hiding this comment.
Suggested change
| raise XMLRPC::FaultException.new(-99, "Method #{name} missing" + | |
| raise XMLRPC::FaultException.new(-99, "Method \#{name} missing" + |
|
|
||
| s = XMLRPC::CGIServer.new | ||
|
|
||
| s.add_handler("test.add") do |a,b| |
There was a problem hiding this comment.
Suggested change
| s.add_handler("test.add") do |a,b| | |
| s.add_handler("test.add") do |a, b| |
| a + b | ||
| end | ||
|
|
||
| s.add_handler("test.div") do |a,b| |
There was a problem hiding this comment.
Suggested change
| s.add_handler("test.div") do |a,b| | |
| s.add_handler("test.div") do |a, b| |
| assert_equal param, 2 | ||
|
|
||
| # introspection | ||
| assert_equal ["test.add", "test.div", "system.listMethods", "system.methodSignature", "system.methodHelp"], @s.call("system.listMethods") |
There was a problem hiding this comment.
Could you avoid omitting parenthesis for assertions?
See also: https://bugs.ruby-lang.org/issues/20922
Could you align long expected and actual for readability?
Suggested change
| assert_equal ["test.add", "test.div", "system.listMethods", "system.methodSignature", "system.methodHelp"], @s.call("system.listMethods") | |
| assert_equal(["test.add", "test.div", "system.listMethods", "system.methodSignature", "system.methodHelp"], | |
| @s.call("system.listMethods")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is mostly a copy-paste from the webrick server test, including the code style.
Because this needs a CGI server, it still has a dependency on webrick to run that server. This setup is a bit slow, on my system the overall execution time of the tests jumps from 1 second to 7 seconds.