Move Prism dependency to gemspec file from Gemfile #347
+24
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* typeprof.gemspec:, Gemfile, Gemfile.lock: Using TypeProf as a
library does not resolve Gemfile dependencies, so move Prism to
gemspec file. Notice that TypeProf now uses Prism version 1.4.0 or
later[1].
[1] Update Prism to 1.4.0 and remove workarounds,
ruby#312
|
The CI failed because this PR not only changed gemspec and Gemfile but also updated Gemfile.lock. Unfortunately, TypeProf didn't support rbs 4.0.0.dev.4. I believe I fixed the failure on master by #348, but I couldn't rebase your branch, so I have created #349 with your commit. Let me merge that PR. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Prism dependency from Gemfile to gemspec. When using TypeProf as a library, Gemfile dependencies are not resolved, so declaring the dependency in the gemspec file is more desirable for library users.
Note that TypeProf now requires Prism version 1.4.0 or later (see #312).
This is a continuation from #288.