Remove object_id use in Set#flatten
#34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
commented
Dec 18, 2023
| set.each { |e| | ||
| if e.is_a?(Set) | ||
| if seen.include?(e_id = e.object_id) | ||
| unless seen.add?(e) |
There was a problem hiding this comment.
There's 3 nice performance wins here:
- We don't trigger a look up (and potentially an assignment) of an object ID
- We can do an identity-based look-up, which is faster
- We combine the
include?andaddsteps into one, saving one hash lookup/comparison.
amomchilov
force-pushed
the
flatten_merge-without-object_id
branch
from
b129c80
to
9c12c2c
Compare
amomchilov
changed the title
object_id use in OpenStruct#inspectobject_id use in Set#flatten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while auditing uses of
object_idinruby/ruby. Pulled out from ruby/ruby#9276.This PR replaces look-ups into a
Setbyobject_ids, with an identity Set (seeSet#compare_by_identity). This has the same semantics but is faster and doesn't trigger allocation of IDs for these objects.