Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rubies for ubuntu-24.04 #17

Closed
wants to merge 1 commit into from
Closed

Build rubies for ubuntu-24.04 #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-20.04, ubuntu-22.04, macos-11, macos-arm-oss ]
os: [ ubuntu-20.04, ubuntu-22.04, ubuntu-24.04, macos-11, macos-arm-oss ]
ruby: [jruby-9.4.7.0]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add other rubies in this matrix for this case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically do it with 1 commit per major.minor, you can see that in existing commits.
IIRC there is some script to easily get such list in this repo or maybe in setup-ruby.
Unfortunately this procedure is not very friendly for PRs.
You could update this one to build all 3.3 releases though, only on 24.04 and if: false on the jruby job below

runs-on: ${{ matrix.os }}
steps:
Expand Down