Integrate debug counters #365
Conversation
|
How about implementing that as a new harness? Do you need to use this on multiple different harnesses? If you create |
|
I can make a harness if you prefer, but I was hoping to use this alongside the |
luke-gruber
force-pushed
the
integrate_ruby_debug_counters
branch
from
5809f79 to
dd710c2
Compare
If we compile ruby with debug counters and use that ruby for running yjit-bench, there's a mess of output due to the ruby subprocesses that get run (ex: `bundle install`). This is because by default, the output is shown at ruby exit. This change adds a new option `--show-debug-counters` that disables all debug counter output for everything except the benchmark scripts. The counters get reset before each benchmark script is run so that the counters during ruby initialization and prelude are not taken into account.
luke-gruber
force-pushed
the
integrate_ruby_debug_counters
branch
from
dd710c2 to
338466a
Compare
|
Oh ok, it seems fair to implement that on the harness-common then. |
| header = "itr: time" | ||
|
|
||
| RubyVM::YJIT.reset_stats! if defined?(RubyVM::YJIT) && RubyVM::YJIT.enabled? | ||
| RubyVM.reset_debug_counters if defined?(RubyVM.reset_debug_counters) |
There was a problem hiding this comment.
So are you fine with this not being used by the vernier harness? I think that's what confused me.
There was a problem hiding this comment.
Since you edited this file, I assume you tested this feature on this default harness. Given there's some overhead in using debug counters, I wonder if you really want to do both debug counters and vernier at the same time. The vernier profiling result could be off due to the overhead of debug counters, so you might want to do them separately anyway.
There was a problem hiding this comment.
Ah okay I understand your concerns. I think you're right, maybe I'll just create a new harness. I'll update the PR later this week 👍
|
I'm no longer interested in using debug counters for benchmarking, so I'm closing this for now. |
2 participants
If we compile ruby with debug counters and use that ruby for running yjit-bench, there's a mess of output due to the ruby subprocesses that get run (ex:
bundle install). This is because by default, the output is shown at ruby exit. This change adds a new option--show-debug-countersthat disables all debug counter output for everything except the benchmark scripts. The counters get reset before each benchmark script is run so that the counters during ruby initialization and prelude are not taken into account.