Fix querying absolute domain name twice #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more assertions to actually test that the ndots option is working as expected: the option controls the threshold that the search list should be attempted earlier or later.
When search list is not explicitly specified, Resolv::DNS checks the local domain name of the running system. If it is not set either, the root domain ['.'] is used. This is conceptually correct, but the code handles the absolute name separately, which in turn creates a duplicate query.
The current code works, but the intention was not clear at first glance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When search list is not explicitly specified, Resolv::DNS checks the local domain name of the running system. If it is not set either, the root domain ['.'] is used.
This is conceptually correct, but the code handles the absolute name separately, which in turn creates a duplicate query.