Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gem fiddle to Gemfile (Only used in windows) #818

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

tompng
Copy link
Member

@tompng tompng commented Feb 15, 2025

Fix ci failure.

Fiddle is only used in windows. I think we need to do these later

  • Show a warning message when require 'fiddle fails
  • Determine which to use: Reline::Windows(fiddle) or Reline::ANSI(no fiddle) without using fiddle in windows.

@st0012 st0012 merged commit 0521bdf into ruby:master Feb 15, 2025
44 checks passed
@tompng tompng deleted the gemfile_fiddle branch February 16, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants