Restore gemspec file to gem package #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in ruby/ruby repo
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Jan 28, 2025
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Jan 28, 2025
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Jan 29, 2025
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Feb 3, 2025
This commit addresses the Rails Nightly CI failure since: https://buildkite.com/rails/rails-nightly/builds/1694#0194b3e0-213e-441d-b977-8c32f4ed1524 This workaround can be reverted when the newer version of `net-smtp` is released that includes ruby/net-smtp#90 - Steps to reproduce ```ruby cd rails git clone https://github.com/rails/buildkite-config .buildkite/ RUBY_IMAGE=rubylang/ruby:master docker compose -f .buildkite/docker-compose.yml build base && CI=1 docker compose -f .buildkite/docker-compose.yml run default runner actiontext 'rake test' ``` - Actual result without this commit ``` +++ actiontext: rake test /usr/local/bin/ruby -w -I"lib:test" /usr/local/lib/ruby/gems/3.5.0+0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/integration/controller_render_test.rb" "test/integration/job_render_test.rb" "test/integration/mailer_render_test.rb" "test/javascript_package_test.rb" "test/models/table_name_test.rb" "test/template/form_helper_test.rb" "test/unit/attachable_test.rb" "test/unit/attachment_test.rb" "test/unit/content_test.rb" "test/unit/fixture_set_test.rb" "test/unit/model_encryption_test.rb" "test/unit/model_test.rb" "test/unit/plain_text_conversion_test.rb" "test/unit/strict_loading_test.rb" "test/unit/trix_attachment_test.rb" /usr/local/lib/ruby/gems/3.5.0+0/gems/capybara-3.40.0/lib/capybara/session/config.rb:95: warning: URI::RFC3986_PARSER.make_regexp is obsolete. Use URI::RFC2396_PARSER.make_regexp explicitly. /usr/local/lib/ruby/gems/3.5.0+0/bundler/gems/httpclient-d57cc6d5ffee/lib/httpclient/util.rb:71: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information) /usr/local/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require': cannot load such file -- net/smtp (LoadError) Did you mean? net/sftp from /usr/local/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'block (2 levels) in Kernel#replace_require' ``` Refer to ruby/net-smtp#90 ruby/ruby#12659
4 tasks
|
I'm not sure if this was sufficient. I tried to put |
|
Simpler repro: require "bundler/inline"
gemfile do
gem "net-smtp", "0.5.1"
end
require "net/smtp"This fails on ruby-head. |
|
@byroot I'll investigate that. I think rubygems/rubygems#8456 is same issue. |
|
fixed at ruby/ruby#12708 |
byroot
referenced
this pull request
in rails/rails
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is required by
rbinstall.rbin ruby/ruby repo.