♻️ Reorganize Config.version_defaults creation
#412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorganizes the creation of `Config.version_defaults` to make it easier to cherry-pick backported config changes to stable branches: * Sets `Config[0.5]` as a diff from the previous versioned default, just like the other versioned defaults. * Sets `Config[:current] = Config[VERSION.to_f]`, so it will not need to be updated for any x.y.0 release. Likewise, sets `Config[:next]` and `Config[:future]` to `Config[VERSION.to_f + 0.1]` or `+ 0.2`, so they which will only rarely need to be changed. * Because `Config[:default]` and `Config[:current]` are now derived two different ways, both a warning and a test have been added to ensure they remain synchronized. * A few other `Config.version_defaults` tests were added or updated.
nevans
changed the title
Config.version_defaults creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorganizes the creation of
Config.version_defaultsto make it easier to cherry-pick backported config changes to stable branches, and to require fewer updates for newx.y.0releases:Config[0.5]as a diff from the previous versioned default, just like the other versioned defaults.Config[:current] = Config[VERSION.to_f], so it will not need to be updated for any x.y.0 release. Likewise, setsConfig[:next]andConfig[:future]toConfig[VERSION.to_f + 0.1]or+ 0.2, so they which will only rarely need to be changed.Config[:default]andConfig[:current]are now derived two different ways, both a warning and a test have been added to ensure they remain synchronized.Config.version_defaultstests were added or updated.