Skip to content

♻️ Minor Config class tidy up #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2024
Merged

♻️ Minor Config class tidy up #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed435f
♻️ Switch Config autoload to require_relative
nevans Jun 14, 2024
a9d06ea
📚 Simplify Config defaults documentation
nevans Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/net/imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,8 +725,6 @@ class IMAP < Protocol
"UTF8=ONLY" => "UTF8=ACCEPT",
}.freeze

autoload :Config, File.expand_path("imap/config", __dir__)

autoload :SASL, File.expand_path("imap/sasl", __dir__)
autoload :SASLAdapter, File.expand_path("imap/sasl_adapter", __dir__)
autoload :StringPrep, File.expand_path("imap/stringprep", __dir__)
Expand Down Expand Up @@ -2981,6 +2979,7 @@ def self.saslprep(string, **opts)
end

require_relative "imap/errors"
require_relative "imap/config"
require_relative "imap/command_data"
require_relative "imap/data_encoding"
require_relative "imap/flags"
Expand Down
12 changes: 3 additions & 9 deletions lib/net/imap/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ def self.[](config) # :nodoc: unfinished API

# The debug mode (boolean)
#
# | Starting with version | The default value is |
# |-----------------------|----------------------|
# | _original_ | +false+ |
# The default value is +false+.
attr_accessor :debug, type: :boolean

# method: debug?
Expand All @@ -72,17 +70,13 @@ def self.[](config) # :nodoc: unfinished API
# If the IMAP object cannot open a connection within this time,
# it raises a Net::OpenTimeout exception. See Net::IMAP.new.
#
# | Starting with version | The default value is |
# |-----------------------|----------------------|
# | _original_ | +30+ seconds |
# The default value is +30+ seconds.
attr_accessor :open_timeout, type: Integer

# Seconds to wait until an IDLE response is received, after
# the client asks to leave the IDLE state. See Net::IMAP#idle_done.
#
# | Starting with version | The default value is |
# |-----------------------|----------------------|
# | _original_ | +5+ seconds |
# The default value is +5+ seconds.
attr_accessor :idle_response_timeout, type: Integer

# Creates a new config object and initialize its attribute with +attrs+.
Expand Down