Break and return false in forced_brace_bounds? when Parent is a Binary

[weizheheng]

Fixes #122

Signed-off-by: Wei Zhe Heng [email protected]

[weizheheng]

Thank you for this gem, I am enjoying it with the Neovim integration so far.

While going through the issue #122, it seems like the Binary node check should be added to #forced_brace_bounds? instead of #unchangeable_bounds?.

While adding a few tests, there is this test case that caught my attention:

Actual Behavior

• Should the barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any? have the same indentation here?

foo =
  barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr if foooooooooooooooooooooo ||
  barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any? do |bar|
    bazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
  end

What I expected

• Extra indentation at the barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any?

foo =
  barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr if foooooooooooooooooooooo ||
    barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any? do |bar|
      bazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
    end

Or should it be

if foooooooooooooooooooooo ||
     barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any? do |bar|
       bazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
     end
  foo = barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr
end

[kddnewton]

Thank you so much for the pull request! This is very detailed in the tests, which I appreciate.

I think it should be

if foooooooooooooooooooooo ||
     barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any? do |bar|
       bazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
     end
  foo = barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr
end

at this point the modifier form of the if is too hard to read, so we should switch to multi-line.

[kddnewton]

@weizheheng would you mind rebasing off main?

[weizheheng]

@kddnewton Hi, yes of course, I'm on vacation now but will be back in three days. Will do it once I'm back.

[weizheheng]

@kddnewton Done rebasing. This PR is purely fixing #122.

Will probably look into the below in a different PR.

Thank you so much for the pull request! This is very detailed in the tests, which I appreciate.

I think it should be

if foooooooooooooooooooooo ||
     barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.any? do |bar|
       bazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
     end
  foo = barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr
end

at this point the modifier form of the if is too hard to read, so we should switch to multi-line.

[kddnewton]

Thank you!

[kddnewton]

@weizheheng looks like this failed CI on an idempotency check. You can check it locally with CI=true bundle exec rake. It checks the .rb files that ship with ruby itself.