-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New feature : linting #2557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New feature : linting #2557
Conversation
Add spec All specs are now linted
Here's an example of a CHANGELOG.md entry: * [#2557](https://github.com/ruby-grape/grape/pull/2557): New feature : linting - [@ericproulx](https://github.com/ericproulx). Generated by 🚫 Danger |
Should we call it But thinking about it, maybe we need something more generic that allows one to inject middleware here, including potentially the ability to remove |
Add `yaml-dev` in Dockerfile
The middleware stack lacks a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this in the README if you want it merged.
That said, also consider not merging this and doing a configurable middleware implementation instead.
This PR adds a linting feature that can activated through
Grape.config.lint = true
orlint!
in aGrape::Api
.Suggested in this comment.
By design, Grape's CI has
Grape.config.lint = true
, so all specs calling an endpoint are linted.