Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1953,6 +1953,73 @@ end
end
----

=== `else` branches after loop exit [[else-after-loop-exit]]

There is no need to wrap code inside an `else` when the `if` statement skips the rest of the loop.

[source,ruby]
----
# bad
[0, 1, 2, 3].each do |item|
if some_condition
do_something
next
else
do_something_else
end
end

# good
[0, 1, 2, 3].each do |item|
if some_condition
do_something
next
end

do_something_else
end

# bad
[0, 1, 2, 3].each do |item|
if some_condition
do_something
break
else
do_something_else
end
end

# good
[0, 1, 2, 3].each do |item|
if some_condition
do_something
break
end

do_something_else
end

# bad
[0, 1, 2, 3].each do |item|
if some_condition
do_something
return
else
do_something_else
end
end

# good
[0, 1, 2, 3].each do |item|
if some_condition
do_something
return
end

do_something_else
end
----

== Exceptions

=== `raise` vs `fail` [[prefer-raise-over-fail]]
Expand Down