Add Rails/HashKeyValueRoute cop
#1329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r7kamura
force-pushed
the
hash-key-value-route
branch
2 times, most recently
from
2dde4fa
to
97b85d7
Compare
Earlopain
reviewed
Aug 14, 2024
| module RuboCop | ||
| module Cop | ||
| module Rails | ||
| # Avoid Hash key-value routing. |
There was a problem hiding this comment.
Let's add the deprecation from 7.2 as a rational for this cop? This is very sparse.
There was a problem hiding this comment.
Thanks, I've added a little more explanation based on the Rails' deprecation message.
There was a problem hiding this comment.
That's good, thanks! And my bad, it'll only be deprecated in 8.0 (removed in 8.1) like you correctly wrote.
r7kamura
force-pushed
the
hash-key-value-route
branch
from
97b85d7
to
ca81897
Compare
|
FYI, it was reverted in rails/rails@5c0b749 |
|
As shown in the information provided by @zzak, the deprecation was reverted. Since the reason for prioritizing this syntax is now unclear, I will close this. Thank you for opening this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cop for the routing style deprecated by the following pull request:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.