ci: pass client-id instead of the legacy app-id

[rubicon]

What changed and why

actions/create-github-app-token is being passed the legacy app-id input. Its README recommends client-id, and its runtime emits a warning naming app-id as deprecated. Nothing is broken and no removal has been announced, so this is hardening rather than a repair.

Two lines: the action now receives client-id, and the 1Password reference points at the matching client id field on the same item. The reference stays addressed by item UUID rather than title, so renaming the item cannot break it.

Closes #40

How it was verified

• op read resolves op://Automation/lnacky4l2tmlihrockbutkub7y/client id (20 characters, Iv23li… prefix, the documented GitHub App client ID shape).
• op read still resolves .../private key, which this change does not touch.
• The edit was applied programmatically with assertions rather than by hand. The transform requires exactly one app id op reference and exactly one matching app-id: input, and asserts afterwards that no app-id: remains, that there is exactly one /client id, and exactly one /private key. It refuses to touch a file that does not match that shape.
• The variable rename follows this repository's own existing naming, so the diff stays two lines and does not restyle the workflow.

Part of a 15-repository sweep. The identical change was landed and proven on rubicon/daxdavis-com first rather than rolled out everywhere on an assumption.

Checklist

• Conventional Commits title
• Branch named dev/<issue>-<slug>
• Commits are signed
• CI is green

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: cbd7c08d-7446-4f14-ad54-eecd1a774382

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}