Limit Precision of Time values written to Migrations table #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using a database (SingleStore) that can't support more than 6 milliseconds of precision when inserting timestamp values into its database. When migrations are executed, the insert into the tracking table fails. This PR introduces a limit precision option that rounds timestamps prior to their insertion into the migrations table.
I added test coverage on the
sql-parse/config.go(both my functionality and previously existing).If this is too specific, the limit precision option could be modified to provide a variable rounding option so that it's more adaptable/reusable to other scenarios (I know it's a bit niche atm)