-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push notifications #429
base: develop
Are you sure you want to change the base?
Push notifications #429
Conversation
Added icon set and manifest.json required for push notifications.
… dispatch push notifications.
"background_color": "#000000", | ||
"display": "browser", | ||
"Scope": "PsyTD/formr-entwicklung", | ||
"start_url": "https://www.uni-muenster.de/PsyTD/formr-entwicklung", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check if we can insert this dynamically.
webroot/sw.js
Outdated
}); | ||
|
||
if (client !== undefined) { | ||
client.navigate('https://www.uni-muenster.de/PsyTD/formr-entwicklung/NeuesQueuingSystemTest'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the run needs to be inserted here. Should be part of the push notification.
@mpw-wwu Please could you create a new feature branch too called feature/push-notifications under rubenarslan/formr.org ? and let's merge this pull request there? |
Sure I can do that. Having a pull request allows us to view the changes easily on here and do reviews on the code as Github provides a nice web ui for that. I'll do some more changes today and push it into the requested feature branch. |
Workaround for this issue: web-push-libs/web-push-php#108
Hello Co-Developers,
this is the push-code that I've written so far. It is basically in working state. But has some issues that need to be addressed.
This pull request is not meant to be merged. It's just a basis for discussion of further steps.
Best,
Matthias