fix: include "Finished" line in cargo build/check success output#763
Open
mvanhorn wants to merge 1 commit intortk-ai:developfrom
Open
fix: include "Finished" line in cargo build/check success output#763mvanhorn wants to merge 1 commit intortk-ai:developfrom
mvanhorn wants to merge 1 commit intortk-ai:developfrom
Conversation
Contributor
|
Hello, thanks for contributing with this fix, Please target develop branch and read CONTRIBUTING.md so you can pass all checks, |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3d8e6e5 to
4a06317
Compare
Contributor
Author
|
Rebased onto develop and retargeted the PR base. Thanks for the heads up on CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the cargo
Finished ...line in the filtered success output forrtk cargo buildandrtk cargo check. Previously, success output only showedcargo build (0 crates compiled)which was ambiguous - LLMs couldn't tell if the build succeeded or if there were errors.Why this matters
Per #759, Claude interpreted
cargo build (0 crates compiled)as potentially erroneous and tried workarounds (rtk proxy cargo check,RUSTFLAGS="-D warnings" rtk proxy cargo check), consuming extra tokens. Claude expected to see theFinished dev profile ...message as a clear success signal.Changes
src/cargo_cmd.rs: Infilter_cargo_build(), capture theFinishedline instead of skipping it, and append it to the success summary. The output now looks like:Testing
All 38
cargo_cmdtests pass (cargo test cargo_cmd). The change only affects the success path - error/warning output is unchanged.Fixes #759
This contribution was developed with AI assistance (Claude Code).