feat(discover): handle more npm/npx/pnpm/pnpx patterns#355
Open
KuSh wants to merge 3 commits intortk-ai:developfrom
Open
feat(discover): handle more npm/npx/pnpm/pnpx patterns#355KuSh wants to merge 3 commits intortk-ai:developfrom
KuSh wants to merge 3 commits intortk-ai:developfrom
Conversation
KuSh
commented
Mar 6, 2026
KuSh
commented
- handle npm exec|run and their aliases
- handle pnpm exec|run and their aliases like npm
- handle pnpx and its alias like npx
- handle all forms of js script/package execution
Collaborator
|
LGTM — solid coverage of npm/npx/pnpm/pnpx patterns with thorough tests (622 pass, fmt + clippy clean). One thing needed before merge: rebase on master — there's a conflict (master has moved since v0.25.0). git fetch origin master && git rebase origin/masterOnce rebased, this is ready to merge. |
Author
|
@pszymkowiak done! |
|
Could you add bun and bunx format as well ? |
Author
|
@navidemad could that be done in another PR? I'm not giving up and will try to propose something but I don't know bun nor use it, I'll have to read the doc a little bit before having something ready |
Author
|
@pszymkowiak rebased on develop, should be ready to merge |
|
|
- handle npm exec|run and their aliases - handle pnpm exec|run and their aliases like npm - handle pnpx and its alias like npx - handle all forms of js script/package execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.