Render 'No newline at end of file' at the end of files #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2025 16:34
For files missing a return character at the end of the file, the git warning will now be rendered instead of being stripped out of the block lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
This is an initial attempt at enabling the git warning for a missing newline character at the end of the file.
There are 3 different scenarios where this can occur, if the old changes contained the missing character, the new changes are missing it, or if both old and new are missing the character.
While the line-by-line renderer was able to work with the warning simply classified as a context line, this was not the case for side-by-side.
In side-by-side rendering, it would insert the message in both sides even if it was only applicable to one or the other. So a little more legwork was required to capture that metadata in order to appropriately insert it and a corresponding empty line for the other side.
In issue #157, I found a linked PR with some files missing newline characters I used as guidance (azaria-dedmon/covid-19#37)
Here is the demo app rendering them in both
Line-by-Line
Side-by-Side
