Skip to content

fix(webshot): Rethrow underlying chromote errors #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(webshot): Rethrow underlying chromote errors #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9286b46
fix(webshot): Rethrow underlying chromote errors
gadenbuie Oct 1, 2024
a32e5f7
docs: Add news item
gadenbuie Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# webshot2 (development version)

* `webshot()` now surfaces errors that occur when working with the lower-level screenshot API provided by Chrome via `{chromote}`. (#69)

# webshot2 0.1.1

* `webshot()` now supports JPEG (`.jpg` or `.jpeg`) and WEBP (`.webp`) image formats. (@trafficonese #45)
Expand Down
9 changes: 8 additions & 1 deletion R/webshot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ new_session_screenshot <- function(


s <- NULL
err <- NULL

p <- chromote$new_session(wait_ = FALSE,
width = vwidth,
Expand Down Expand Up @@ -296,8 +297,14 @@ new_session_screenshot <- function(
if (!isTRUE(quiet)) message(url, " screenshot completed")
normalizePath(value)
})$
catch(function(err) {
err <<- err
})$
finally(function() {
s$close()
# Close down the session if we successfully started one
if (!is.null(s)) s$close()
# Or rethrow the error if we caught one
if (!is.null(err)) signalCondition(err)
})

p
Expand Down