allow JPG / JPEG, add verbose argument #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Thanks @trafficonese! I left a few comments below, primarily around the naming of the new argument -- I'd prefer quiet instead of verbose in this case.
What do you think about adding .webp to the list of supported screenshot file types as well? https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-captureScreenshot
|
|
|
@trafficonese Thank you for this PR! I'd like to get this into the next release of webshot2, so I went ahead and finished up the PR. Can you please sign the Contributor License Agreement so that we can accept this PR? Thank you! @wch @cpsievert Would you mind giving this PR a quick review? |
wch
approved these changes
Aug 10, 2023
|
Thanks @trafficonese! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44, fixes #24