feat(textAreaInput): Add an autoresize option
#4210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
feat/textAreaAutoResize
branch
from
cad1639 to
e0fc4dc
Compare
cpsievert
commented
Apr 25, 2025
wch
reviewed
Apr 25, 2025
Rules aren't being applied correctly in PyShiny either...
cpsievert
force-pushed
the
feat/textAreaAutoResize
branch
from
70aae7c to
c672ee9
Compare
|
@wch ok to merge? |
wch
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
autoresizeoption totextAreaInput(). WhenTRUE, the input will automatically resize the height to the contents of the input.Note this effectively backports this feature from Python (posit-dev/py-shiny#463) to R.
In this PR, I decided to bundle the autoresize logic with "core" Shiny assets, removing the need for another dependency. This is handy since I'd also like re-use this logic for another component in rstudio/bslib#1204.
IMPORTANT: if we do end up bundling the autoresize logic with shiny.js, py-shiny should get updated to gut the autoresize dependency.