Skip to content

Conversation

michaelmayer2
Copy link
Contributor

This PR will trigger the installation of the appropriate system dependencies for s2 and hence speed up package installation.

@rstudio-pm
Copy link

rstudio-pm commented May 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@michaelmayer2 michaelmayer2 mentioned this pull request May 23, 2025
Copy link
Contributor

@glin glin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions but looks good, and thanks for updating sysreqs.json. At some point we should probably just add a GHA scheduled job that updates it.

{
"packages": ["abseil-cpp-devel"],
"pre_install": [
{ "command": "subscription-manager repos --enable codeready-builder-for-rhel-8-$(arch)-rpms" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CodeReady Builder really necessary if the Rocky Linux 8 sysreqs only require EPEL alone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will remove this, it does not seem to be necessary, judging from my installation attempt in a redhat/ubi8 container, see below.

[root@0b29a43d118f /]# yum install abseil-cpp-devel
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Extra Packages for Enterprise Linux 8 - x86_64   19 MB/s |  14 MB     00:00    
Last metadata expiration check: 0:00:07 ago on Tue May 27 17:11:55 2025.
Dependencies resolved.
================================================================================
 Package            Arch     Version               Repository              Size
================================================================================
Installing:
 abseil-cpp-devel   x86_64   20200923.3-1.el8      epel                   576 k
Installing dependencies:
 abseil-cpp         x86_64   20200923.3-1.el8      epel                   485 k
 cmake-filesystem   x86_64   3.26.5-2.el9          ubi-9-appstream-rpms    23 k

Transaction Summary
================================================================================
Install  3 Packages

Total download size: 1.1 M
Installed size: 4.4 M
Is this ok [y/N]: y
Downloading Packages:
(1/3): cmake-filesystem-3.26.5-2.el9.x86_64.rpm 148 kB/s |  23 kB     00:00    
(2/3): abseil-cpp-devel-20200923.3-1.el8.x86_64 2.7 MB/s | 576 kB     00:00    
(3/3): abseil-cpp-20200923.3-1.el8.x86_64.rpm   2.2 MB/s | 485 kB     00:00    
--------------------------------------------------------------------------------
Total                                           2.7 MB/s | 1.1 MB     00:00     
Extra Packages for Enterprise Linux 8 - x86_64  1.6 MB/s | 1.6 kB     00:00    
Importing GPG key 0x2F86D6A1:
 Userid     : "Fedora EPEL (8) <[email protected]>"
 Fingerprint: 94E2 79EB 8D8F 25B2 1810 ADF1 21EA 45AB 2F86 D6A1
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-8
Is this ok [y/N]: y
Key imported successfully
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                        1/1 
  Installing       : cmake-filesystem-3.26.5-2.el9.x86_64                   1/3 
  Installing       : abseil-cpp-20200923.3-1.el8.x86_64                     2/3 
  Installing       : abseil-cpp-devel-20200923.3-1.el8.x86_64               3/3 
  Running scriptlet: abseil-cpp-devel-20200923.3-1.el8.x86_64               3/3 
  Verifying        : abseil-cpp-20200923.3-1.el8.x86_64                     1/3 
  Verifying        : abseil-cpp-devel-20200923.3-1.el8.x86_64               2/3 
  Verifying        : cmake-filesystem-3.26.5-2.el9.x86_64                   3/3 
Installed products updated.

Installed:
  abseil-cpp-20200923.3-1.el8.x86_64   abseil-cpp-devel-20200923.3-1.el8.x86_64
  cmake-filesystem-3.26.5-2.el9.x86_64

Complete!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 968bf4d

Copy link
Contributor

@glin glin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@glin glin merged commit feb8a42 into rstudio:main May 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants