Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for invalid regexp patterns #187

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add test for invalid regexp patterns #187

merged 2 commits into from
Sep 18, 2024

Conversation

glin
Copy link
Contributor

@glin glin commented Sep 18, 2024

Test for more invalid regexp patterns using Unicode-aware mode. RegExp in JavaScript apparently doesn't check for many invalid syntax cases, but this u mode does.

$ npm test

SyntaxError: Invalid regular expression: /\libmecab\b/u: Invalid escape
    at new RegExp (<anonymous>)

Fix another escape issue with poppler.

@glin glin changed the title Test regexp Add test for invalid regexp patterns Sep 18, 2024
@glin glin requested a review from jmwoliver September 18, 2024 19:22
@glin glin merged commit f69e289 into main Sep 18, 2024
46 checks passed
@glin glin deleted the test-regexp branch September 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants